Skip to content

fix: send launch options to remote browsers with protocol option names - #349

Merged
Yury Semikhatsky (yury-s) merged 1 commit into
mainfrom
fix-remote-launch-options
Nov 13, 2026
Merged

Yury Semikhatsky (yury-s) merged 1 commit into
mainfrom
fix-remote-launch-options

Conversation

@yury-s

Copy link
Copy Markdown
Member

When `connect_options` is set, the launch options are sent to the server as JSON in the `x-playwright-launch-options` header. The server reads them with the protocol option names (`slowMo`, `firefoxUserPrefs`, `chromiumSandbox`, ...), but the plugin sent the Python names (`slow_mo`, ...), so every multi-word option was silently ignored. In particular `--slowmo` had no effect on remote browsers.

The option names are now converted to camelCase before they are sent, in both the sync and the asyncio plugin. Only the top-level names are converted; values such as `firefox_user_prefs` are passed as is.

`test_connect_options_should_work` now also runs with `--slowmo` against the server and checks that the clicks are slowed down, for both plugins. The tests fail without the fix.

Supersedes #348, which converts `slow_mo` only.

@yury-s
Yury Semikhatsky (yury-s) merged commit d9f2810 into main Nov 13, 2026
16 checks passed
@yury-s
Yury Semikhatsky (yury-s) deleted the fix-remote-launch-options branch November 13, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants